Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move js demo examples to ts #2794

Merged
merged 24 commits into from
Feb 12, 2024
Merged

move js demo examples to ts #2794

merged 24 commits into from
Feb 12, 2024

Conversation

Burnett2k
Copy link
Member

@Burnett2k Burnett2k commented Feb 8, 2024

Description

We are working to remove the code within the demo/js folder, so that we don't have to maintain examples in the javascript AND typescript demo. Before deleting, I went through and compared the demos to see if anything was missing.

Findings:

  • a few typescript issues that needed to be fixed to reduce the # of ts errors in the demo project
  • mostly needed to copy / paste over examples that didn't get ported over for some reason

Fixes #2772

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

I went through the ts demo project to ensure examples I modified are showing up correctly.

Checklist: (Feel free to delete this section upon completion)

  • I have included a changeset if this change will require a version change to one of the packages.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have run all builds, tests, and linting and all checks pass
  • I have added tests that prove my fix is effective or that my feature works
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link

changeset-bot bot commented Feb 8, 2024

🦋 Changeset detected

Latest commit: 29964ad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
victory-brush-container Patch
victory-candlestick Patch
victory-area Patch
victory-axis Patch
victory-bar Patch
victory-box-plot Patch
victory-brush-line Patch
victory-canvas Patch
victory-chart Patch
victory-core Patch
victory-create-container Patch
victory-cursor-container Patch
victory-errorbar Patch
victory-group Patch
victory-histogram Patch
victory-legend Patch
victory-line Patch
victory-native Patch
victory-pie Patch
victory-polar-axis Patch
victory-scatter Patch
victory-selection-container Patch
victory-shared-events Patch
victory-stack Patch
victory-tooltip Patch
victory-vendor Patch
victory-voronoi-container Patch
victory-voronoi Patch
victory-zoom-container Patch
victory Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
victory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2024 3:50pm

move last example into svg
@Burnett2k Burnett2k marked this pull request as ready for review February 9, 2024 22:36
package.json Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge js demo into ts demo
2 participants