add types for create container, rm invalid prop #2932
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes
create-container-demo
passing an outdated prop,selectedDomain
and it not being caught by TS. This was due to theany
on the container as well as an implicitany
on the demo's prop types. Removing this value instead of trying to map it to the new properties (likezoomDomain
) has the fewest changes to the result.Type of Change
How Has This Been Tested?
Run demo locally
Checklist: (Feel free to delete this section upon completion)