Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add types for create container, rm invalid prop #2932

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

nlkluth
Copy link
Member

@nlkluth nlkluth commented Oct 28, 2024

Description

Fixes create-container-demo passing an outdated prop, selectedDomain and it not being caught by TS. This was due to the any on the container as well as an implicit any on the demo's prop types. Removing this value instead of trying to map it to the new properties (like zoomDomain) has the fewest changes to the result.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Run demo locally

Checklist: (Feel free to delete this section upon completion)

  • I have included a changeset if this change will require a version change to one of the packages.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have run all builds, tests, and linting and all checks pass
  • I have added tests that prove my fix is effective or that my feature works
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Screenshot 2024-10-28 at 10 24 23 AM

Copy link

changeset-bot bot commented Oct 28, 2024

⚠️ No Changeset found

Latest commit: d10dd02

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
victory ⬜️ Ignored (Inspect) Oct 28, 2024 4:27pm

@nlkluth nlkluth requested a review from sblinde October 28, 2024 16:29
@nlkluth nlkluth merged commit 953e0ad into main Oct 28, 2024
6 checks passed
@nlkluth nlkluth deleted the create-container-demo-types branch October 28, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants