Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 'Pie Chart ignores categories prop' #2934

Merged
merged 7 commits into from
Oct 30, 2024
Merged

Conversation

nstolpe
Copy link
Contributor

@nstolpe nstolpe commented Oct 28, 2024

Description

Adds logic to sort pie chart slices by the categories in categories prop. Adds a story as well.

Fixes #2921

Copy link

changeset-bot bot commented Oct 28, 2024

🦋 Changeset detected

Latest commit: 1404133

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
victory-pie Patch
victory Patch
rn-demo Patch
victory-area Patch
victory-axis Patch
victory-bar Patch
victory-box-plot Patch
victory-brush-container Patch
victory-brush-line Patch
victory-candlestick Patch
victory-canvas Patch
victory-chart Patch
victory-core Patch
victory-create-container Patch
victory-cursor-container Patch
victory-errorbar Patch
victory-group Patch
victory-histogram Patch
victory-legend Patch
victory-line Patch
victory-native Patch
victory-polar-axis Patch
victory-scatter Patch
victory-selection-container Patch
victory-shared-events Patch
victory-stack Patch
victory-tooltip Patch
victory-vendor Patch
victory-voronoi-container Patch
victory-voronoi Patch
victory-zoom-container Patch
victory-docs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
victory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 5:59pm

@nstolpe nstolpe changed the title fix 'Pie hart ignores fix 'Pie Chart ignores categories prop' Oct 28, 2024
@nstolpe nstolpe marked this pull request as draft October 28, 2024 18:29
@nstolpe nstolpe marked this pull request as ready for review October 28, 2024 21:01
@nstolpe nstolpe force-pushed the fix/pie-chart-ignores-categories branch from 849cc31 to 0103054 Compare October 29, 2024 13:55
@nstolpe nstolpe merged commit ba6f55b into main Oct 30, 2024
9 checks passed
@nstolpe nstolpe deleted the fix/pie-chart-ignores-categories branch October 30, 2024 18:06
@github-actions github-actions bot mentioned this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pie Chart ignores categories prop
2 participants