Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate types from interfaces #2940

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Conversation

carbonrobot
Copy link
Contributor

@carbonrobot carbonrobot commented Oct 30, 2024

Several components had props interface definitions with duplicate type definitions. These interfaces extend and underlying type and do not need to redefine the properties.

Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
victory ❌ Failed (Inspect) Oct 30, 2024 11:03pm

Copy link

changeset-bot bot commented Oct 30, 2024

🦋 Changeset detected

Latest commit: b931780

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
victory-area Patch
victory-axis Patch
victory-bar Patch
victory-candlestick Patch
victory-core Patch
victory-errorbar Patch
victory-group Patch
victory-histogram Patch
victory-line Patch
victory-pie Patch
victory-polar-axis Patch
victory-stack Patch
victory Patch
rn-demo Patch
victory-chart Patch
victory-canvas Patch
victory-box-plot Patch
victory-brush-container Patch
victory-brush-line Patch
victory-create-container Patch
victory-cursor-container Patch
victory-legend Patch
victory-scatter Patch
victory-selection-container Patch
victory-shared-events Patch
victory-tooltip Patch
victory-voronoi-container Patch
victory-voronoi Patch
victory-zoom-container Patch
victory-native Patch
victory-vendor Patch
victory-docs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@carbonrobot carbonrobot merged commit 16e5415 into main Nov 1, 2024
7 of 8 checks passed
@carbonrobot carbonrobot deleted the chore/remove-dup-types branch November 1, 2024 13:02
@github-actions github-actions bot mentioned this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants