Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Box plot tooltip workaround example #2956

Merged
merged 5 commits into from
Nov 12, 2024
Merged

Conversation

nlkluth
Copy link
Member

@nlkluth nlkluth commented Nov 7, 2024

Description

Add example of tooltip event overrides for box plot

Workaround for #2621. Issue still unresolved.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Local demo added to docs

Checklist: (Feel free to delete this section upon completion)

  • I have included a changeset if this change will require a version change to one of the packages.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have run all builds, tests, and linting and all checks pass
  • I have added tests that prove my fix is effective or that my feature works
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
Screen.Recording.2024-11-12.at.10.15.38.AM.mov

Copy link

changeset-bot bot commented Nov 7, 2024

⚠️ No Changeset found

Latest commit: b2f0cf8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
victory ✅ Ready (Inspect) Visit Preview Nov 12, 2024 5:17pm

Copy link
Contributor

github-actions bot commented Nov 7, 2024

Folder/File Previous size New size Difference
/packages/victory/dist/victory.min.js 385.54KB 385.63KB +0.08KB (+0.02%)
TOTAL +0.08KB

@nlkluth nlkluth changed the title Tooltip data target labels Box plot tooltip workaround example Nov 12, 2024
@nlkluth nlkluth requested a review from carbonrobot November 12, 2024 17:21
@nlkluth nlkluth merged commit 3e447f2 into main Nov 12, 2024
4 checks passed
@nlkluth nlkluth deleted the tooltip-data-target-labels branch November 12, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants