-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Named OSS Badge Exports #2963
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like all icons are still imported into the production bundles. We may need to add sideEffects: false
to the oss lander package to help Webpack tree shake this properly.
You should be able to test this locally by using pnpm link
between the two projects instead of having to release a new package.
6c82e9c
to
f28fb8c
Compare
6d60634
to
d2d790e
Compare
Looks good, 32KB reduction in bundle size. |
ee01fc5
to
f4afd34
Compare
Description
Update OSS Badges package and use named badge exports to reduce file sizes
Fixes # (issue)
Type of Change
How Has This Been Tested?
Ran website locally to verify new badges render correctly.
Checklist: (Feel free to delete this section upon completion)