Add TypeScript definitions. #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkerziegler
force-pushed
the
feature/229-ts-defs
branch
from
e6c6e3b
to
408481f
Compare
|
@ryan-roemer realized I was type checking the CLI options, not the Dashboard options 🤦♂️. Pinging for re-review if you have a second! |
ryan-roemer
reviewed
Jan 29, 2019
| @@ -0,0 +1 @@ | |||
| dist-* | |||
There was a problem hiding this comment.
Yep – this is precautionary. When a user runs yarn dev it'll generate the bundle.js file for the built fixture (whichever one they use). Rather than relying on a user to delete that file in order to pass local linting scripts, I figured we'd just tell ESLint to ignore these files altogether. Does that make sense?
ryan-roemer
approved these changes
Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds basic TypeScript definitions to
webpack-dashboard. Since our API surface is so small – it essentially consists of the possible options you can pass to theDashboardplugin – this is a fairly minor patch. It's really intended for those souls who really, really want to write awebpack.config.ts. I'd ideally like to roll this and theinspectpackupgrade together into a 2.1.0 release if that sounds good to you @ryan-roemer.Some highlights:
colorpassed toDashboardto ensure that it's a supported ANSI color as per the colors outlined here: https://github.com/chalk/ansi-styles#colors. These are the colors supported bychalk, but I noticed that the*-Brightvariants don't get picked up 😞. The ones included are confirmed to work.index.d.tsfile incheckandcheck-cicommands.webpack.config.tsfile and ensuringtsccaught the errors. We'll want to confirm that this holds true after publishing.This would close #229.