You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The main reason why it was a peer dependency is because it contained a global library variable. Therefore it was important to ensure that there is only one instance of library. Furthermore consumers had to import library from @fortawesome/fontawesome-svg-core, so they often installed it as a directly dependency. This result in two instances and lots of troubles.
angular-fontawesome provides its own FaIconLibrary now and support for icon library from fontawesome-svg-core will be removed in 0.7.0. It is a long standing goal to make fontawesome-svg-core an implementation detail of angular-fontawesome, so consumers don't need to worry about its existence.
To achieve this several things needs to be done:
move @fortawesome/fontawesome-svg-core to regular dependencies
ensure that all types from @fortawesome/fontawesome-svg-core used by angular-fontawesome are re-exported
provide ng update command, which will remove @fortawesome/fontawesome-svg-core from user's package JSON not trivial, so the migration will require a manual step
The main reason why it was a peer dependency is because it contained a global
library
variable. Therefore it was important to ensure that there is only one instance of library. Furthermore consumers had to importlibrary
from@fortawesome/fontawesome-svg-core
, so they often installed it as a directly dependency. This result in two instances and lots of troubles.angular-fontawesome
provides its ownFaIconLibrary
now and support for icon library fromfontawesome-svg-core
will be removed in 0.7.0. It is a long standing goal to makefontawesome-svg-core
an implementation detail ofangular-fontawesome
, so consumers don't need to worry about its existence.To achieve this several things needs to be done:
@fortawesome/fontawesome-svg-core
to regular dependencies@fortawesome/fontawesome-svg-core
used byangular-fontawesome
are re-exportedprovidenot trivial, so the migration will require a manual stepng update
command, which will remove@fortawesome/fontawesome-svg-core
from user's package JSONdom.watch()
with Angular know how to achieve itThe text was updated successfully, but these errors were encountered: