Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fas,faCalendarDay icon is not available to export. #214

Closed
crayner opened this issue Dec 30, 2018 · 6 comments
Closed

fas,faCalendarDay icon is not available to export. #214

crayner opened this issue Dec 30, 2018 · 6 comments

Comments

@crayner
Copy link

crayner commented Dec 30, 2018

I am trying to use a the faCalendarDay ICON found in the free-solid library of FontAwesome within a react app. I import the required icons using

    import { FontAwesomeIcon } from '@fortawesome/react-fontawesome'
    import { faCalendar, faCalendarPlus, faCalendarMinus, faUser } from '@fortawesome/free-regular-svg-icons'
    import { faSchool, faCubes, faCalendarDay } from '@fortawesome/free-solid-svg-icons'

but get an error icon not available for export on faCalendarDay. I found that the calendar-day definition is missing from the @fortawesome/fontawesome-common-types/index.d.js in the node_modules directory. Adding 'calendar-day' in this file 3 times fixed the issue. I would do a pull and repair myself but I am unable to find these files in a repository. Sorry.

Craig

@robmadole
Copy link
Member

Hi @crayner. If you can provide a complete reproduction of this we'll give it a look. You can use codesandbox.io or something similar.

@crayner
Copy link
Author

crayner commented Jan 15, 2019

Hi Rob,
The definitions for faCalendarDay are missing from the from the common types index file. Add them there, and the system works as expected. So in my
...\node_modules@fortawesome\free-solid-svg-icons\node_modules@fortawesome\fontawesome-common-types\index.d.ts
I added 'calendar-day' |
at lines 639,2117 and 3595, as the Font Awesome website states that faCalendarDay is a free solid icon. Hope this helps. (I would have done a pull request, but this repository structure is nothing like the installed content, and I did not wish to take the time to find the appropriate file. This file may be pulled from somewhere else on install ????)

Craig.

@robmadole
Copy link
Member

@crayner I've verified that the file faCalendarDay.js and faCalendarDay.d.ts exist in @fortawesome/free-solid-svg-icons. I also verified that the calendar-day icon name exist in the @fortawesome/fontawesome-common-types library.

You might check the versions you have installed and update the dependencies. That's the easiest thing to check. If you still have trouble we must have a reproducible test case using something we can run locally or through a code-sharing site. It's too difficult to debug issues in a JS app without it. I'll re-open this issue if you are still having problems and provide the test case.

@crayner
Copy link
Author

crayner commented Jan 16, 2019 via email

@robmadole
Copy link
Member

@crayner we don't have a 0.1.03 of anything, that's not how we version our libraries or packages. That's the primary reason that we ask our community to provide a reproducible example. There is a lot of ambiguity in your reported issue. And regarding the solution that you gave, we literally can't make that fix because I have verified that there is no issue in the packages that you referred to. That icon exists in those packages.

Are you not willing to provide a reproducible example? I have requested it twice now. The time investment on your end almost always resolves with a fix that will solve your issue. The alternative is that we go round and round, each of us guessing the other one's meaning and very seldom solving the problem.

@crayner
Copy link
Author

crayner commented Jan 16, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants