-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support title and have that work the same as documented accessibility features #97
Comments
Gotcha! Thanks. We'll add this to the list. |
Hi, If it's ok, I'd like to try to add this! |
@mmhand123 of course. Hollar if we can answer any questions. |
@mmhand123 actually I'm not sure what this work is. @jlismore can you be more specific? |
It looked like if we pass title to the icon function from svg-core when it makes the renderedIcon, it would work (and that function would add the title svg element with the proper aria tags), with another small change. |
Please add this! Definitely need it! @robmadole |
@robmadole It looks like @mmhand123's merge request adds the additional property and the tests are passing. What else needs to be done before this can be merged? We're excited to add aria-labelledby to our FontAwesome icons in React! |
Alright folks, 0.1.3 has been released. Let us know if it does not work as expected! |
It seems that react-fontawesome doesn't support the accessibility mode mentioned here.
I can use the techniques mentioned for web fonts in the docs, but it would be nice if adding a title tag to an icon made it accessible.
e.g. would add the correct aria tags
The text was updated successfully, but these errors were encountered: