Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support title and have that work the same as documented accessibility features #97

Closed
jlismore opened this issue Mar 13, 2018 · 8 comments
Assignees

Comments

@jlismore
Copy link

It seems that react-fontawesome doesn't support the accessibility mode mentioned here.
I can use the techniques mentioned for web fonts in the docs, but it would be nice if adding a title tag to an icon made it accessible.
e.g. would add the correct aria tags

@robmadole robmadole changed the title Making accessible icons Support title and have that work the same as documented accessibility features Mar 14, 2018
@robmadole
Copy link
Member

Gotcha! Thanks. We'll add this to the list.

@mmhand123
Copy link
Contributor

Hi,

If it's ok, I'd like to try to add this!

@robmadole
Copy link
Member

@mmhand123 of course. Hollar if we can answer any questions.

@robmadole
Copy link
Member

@mmhand123 actually I'm not sure what this work is. @jlismore can you be more specific?

@mmhand123
Copy link
Contributor

It looked like if we pass title to the icon function from svg-core when it makes the renderedIcon, it would work (and that function would add the title svg element with the proper aria tags), with another small change.

mmhand123 added a commit to mmhand123/react-fontawesome that referenced this issue Aug 22, 2018
@sarahsmo
Copy link

Please add this! Definitely need it! @robmadole

@kishba
Copy link

kishba commented Sep 6, 2018

@robmadole It looks like @mmhand123's merge request adds the additional property and the tests are passing. What else needs to be done before this can be merged? We're excited to add aria-labelledby to our FontAwesome icons in React!

robmadole pushed a commit that referenced this issue Sep 6, 2018
@robmadole
Copy link
Member

Alright folks, 0.1.3 has been released. Let us know if it does not work as expected!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants