forwarding ref to Svg component #116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add TypeScript types, dependent upon the types in the fontawesome API package. * Add example app that uses TypeScript * Add @types/react package to dev dependencies * Reformat with prettier * Moving from default imports to named imports, both in how this component uses the underlying fontawesome API, and in what this component exports to its clients. * Update documentation to remove default export/import.
|
Hey @flienteen we'll have to take a closer look at this. For reference for whomever picks this up: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
in my project i need to ref the icon component.
The problem is that stateless function components cannot be given refs.
Reproductible exemample: https://codesandbox.io/s/k1m442popr
Updated example with React.forwardRef: https://codesandbox.io/s/2p7nzvzowr
Thanks.