Allow string or number for the rotation prop (#171)

FortAwesome · Mar 18, 2019 · f45dfcf · f45dfcf
1 parent 1b3e339
commit f45dfcf
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 6 deletions.
diff --git a/index.es.js b/index.es.js
@@ -389,10 +389,10 @@ var FontAwesomeIcon = {
       default: false
     },
     rotation: {
-      type: Number,
+      type: [String, Number],
       default: null,
       validator: function validator(value) {
-        return [90, 180, 270].indexOf(value) > -1;
+        return [90, 180, 270].indexOf(parseInt(value, 10)) > -1;
       }
     },
     size: {

diff --git a/index.js b/index.js
@@ -393,10 +393,10 @@
 	      default: false
 	    },
 	    rotation: {
-	      type: Number,
+	      type: [String, Number],
 	      default: null,
 	      validator: function validator(value) {
-	        return [90, 180, 270].indexOf(value) > -1;
+	        return [90, 180, 270].indexOf(parseInt(value, 10)) > -1;
 	      }
 	    },
 	    size: {

diff --git a/src/components/FontAwesomeIcon.js b/src/components/FontAwesomeIcon.js
@@ -62,9 +62,9 @@ export default {
       default: false
     },
     rotation: {
-      type: Number,
+      type: [String, Number],
       default: null,
-      validator: (value) => [90, 180, 270].indexOf(value) > -1
+      validator: (value) => [90, 180, 270].indexOf(parseInt(value, 10)) > -1
     },
     size: {
       type: String,

diff --git a/src/components/__tests__/FontAwesomeIcon.test.js b/src/components/__tests__/FontAwesomeIcon.test.js
@@ -165,6 +165,12 @@ describe('using rotation', () => {
 
     expect(vm.$el.classList.contains('fa-rotate-270')).toBeTruthy()
   })
+
+  test('as a string', () => {
+    const vm = mountFromProps({ icon: faCoffee, rotation: '90' })
+
+    expect(vm.$el.classList.contains('fa-rotate-90')).toBeTruthy()
+  })
 })
 
 test('using size', () => {