Make sure tap outside of open group closes group #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there anything I can do to help this PR along? (I guess you might be a little busy managing a few dozen just-forked apps...) |
|
Don't worry, please just wait a bit. Your PR will be checked when the time comes for updating Launcher. |
|
Even small changes like this can have side effects so I have to take a proper look before I hit merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
To ensure the group is always closed, we return
nullin the grid item finder if there is an open folder and no item in the folder was clicked.Before/After Screenshots/Screen Record
Fixes the following issue(s)
Fixes #57
Acknowledgement