Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experimental command for the plugin to show the state of exclusions #1133

Merged
merged 3 commits into from
Apr 2, 2022
Merged

Experimental command for the plugin to show the state of exclusions #1133

merged 3 commits into from
Apr 2, 2022

Conversation

johscheuer
Copy link
Member

Description

Add an experimental plugin command to show the state of exclusions. This command is not finished and has some todos open but already offers some value.

Type of change

Please select one of the options below.

  • New feature (non-breaking change which adds functionality)

Discussion

I will check if the stored_bytes is the best indicator for how long it will take until the process is fully excluded.

Testing

Local.

Documentation

None, will be added once the command is in a stable command.

Follow-up

Finish the to-dos.

@johscheuer johscheuer added the plugin Kubectl plugin label Mar 23, 2022
@foundationdb-ci
Copy link

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: fdb-kubernetes-operator-pr
  • Commit ID: cb1e9bc
  • Result: FAILED
  • Error: Error while executing command: make -C tests -kj prOperator. Reason: exit status 2
  • Build Logs (available for 30 days)

@foundationdb-ci
Copy link

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: fdb-kubernetes-operator-pr
  • Commit ID: cb1e9bc
  • Result: FAILED
  • Error: Error while executing command: make -C tests -kj prOperator. Reason: exit status 2
  • Build Logs (available for 30 days)

@foundationdb-ci
Copy link

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: fdb-kubernetes-operator-pr
  • Commit ID: 898b8d7
  • Result: FAILED
  • Error: Error while executing command: make -C tests -kj prOperator. Reason: exit status 2
  • Build Logs (available for 30 days)

JoshuaMcManus
JoshuaMcManus approved these changes Apr 1, 2022
View reviewed changes
Copy link
Collaborator

@JoshuaMcManus JoshuaMcManus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. A couple suggestions for improvements in the future:

  • Add a '-w' option which uses the looping behaviour, rather than always doing an infinite loop
  • Add an option to check the exclusion status of a specific instance

@johscheuer
Copy link
Member Author

This looks good. A couple suggestions for improvements in the future:

  • Add a '-w' option which uses the looping behaviour, rather than always doing an infinite loop
  • Add an option to check the exclusion status of a specific instance

I'll create issues for those improvements 👍

@johscheuer johscheuer merged commit e117e53 into FoundationDB:main Apr 2, 2022
@johscheuer johscheuer deleted the experimental-exclude-progress branch April 2, 2022 05:45
09harsh pushed a commit to 09harsh/fdb-kubernetes-operator that referenced this pull request Aug 1, 2022
@johscheuer
Experimental command for the plugin to show the state of exclusions (F…
7297008 
…oundationDB#1133)

* Experimental command for the plugin to show the state of exclusions

* Check if we have at least one Pod

* Move status json clear into internal package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaMcManus JoshuaMcManus JoshuaMcManus approved these changes

Assignees
No one assigned
Labels
plugin Kubectl plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johscheuer @foundationdb-ci @JoshuaMcManus