role count fix #1172
Merged
role count fix #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS CodeBuild CI Report for Linux CentOS 7
|
ltsampros
force-pushed
the
feature/ltsampros/role-count-fix
branch
from
1b32ec3
to
9812b21
Compare
AWS CodeBuild CI Report for Linux CentOS 7
|
AWS CodeBuild CI Report for Linux CentOS 7
|
brownleej
requested changes
Apr 19, 2022
| @@ -150,9 +150,19 @@ func (configuration *DatabaseConfiguration) FailOver() DatabaseConfiguration { | |||
| // | |||
| // This will fill in defaults of -1 for some fields that have a default of 0, | |||
| // and will ensure that the region configuration is ordered consistently. | |||
| func (configuration DatabaseConfiguration) NormalizeConfiguration() DatabaseConfiguration { | |||
| func (configuration DatabaseConfiguration) NormalizeConfiguration(version string, areSeparatedProxiesConfigured bool) DatabaseConfiguration { | |||
There was a problem hiding this comment.
This looks like a breaking change. Can we implement this by defining a new function and having the old function call the new one?
There was a problem hiding this comment.
I think this is fixed now.
AWS CodeBuild CI Report for Linux CentOS 7
|
JoshuaMcManus
pushed a commit
to JoshuaMcManus/fdb-kubernetes-operator
that referenced
this pull request
Apr 20, 2022
* fix: apply correct proxy settings per documentation
AWS CodeBuild CI Report for Linux CentOS 7
|
johscheuer
reviewed
Apr 25, 2022
09harsh
pushed a commit
to 09harsh/fdb-kubernetes-operator
that referenced
this pull request
Aug 1, 2022
* fix: apply correct proxy settings per documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1150 #1151.
If proxies are set to 0, then grv_proxies/commit_proxies will be used in the configure string correctly and vice versa. Defaults have been set for all cases and added some extra logic in normalization of the status to account for that so that reconciliation completes.
Type of change
Please select one of the options below.
Testing
Unit tests and local dev environment.