Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for recovery state recovered since #1343

Merged

Conversation

johscheuer
Copy link
Member

Description

Fixes: #804

Type of change

Please select one of the options below.

  • New feature (non-breaking change which adds functionality)

Discussion

I decided to create a flag to enable/disable this feature (enabled per default) to make it easier to remove this in the future (and always use it).

Testing

Local test + unit tests.

Documentation

Follow-up

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 5978f8374e0407cb61f2173929e5310c0a999aaa
  • Duration 4:06:43
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

api/v1beta2/foundationdb_version.go Show resolved Hide resolved
controllers/bounce_processes.go Show resolved Hide resolved
controllers/bounce_processes.go Outdated Show resolved Hide resolved
setup/setup.go Show resolved Hide resolved
@johscheuer johscheuer requested review from brownleej and removed request for AnnigeriShambu and 09harsh September 15, 2022 15:15
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 6d2d3643da71dbaa0894f95099d7af63b1d9cada
  • Duration 4:06:10
  • Result: ❌ FAILED
  • Error: Error while executing command: if $(grep -q -- "--- FAIL:" logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" logs/*.log; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: a8679ae
  • Duration 4:06:15
  • Result: ❌ FAILED
  • Error: Error while executing command: if $(grep -q -- "--- FAIL:" logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" logs/*.log; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

Copy link
Member

@brownleej brownleej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@johscheuer johscheuer merged commit 573cb36 into FoundationDB:main Sep 23, 2022
@johscheuer johscheuer deleted the add-support-for-recovery-state branch September 23, 2022 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using time since last recovery to delay rolling bounces
4 participants