Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If the cluster is upgraded wait for all processes to be ready #1446

Merged
merged 3 commits into from
Nov 30, 2022

Conversation

johscheuer
Copy link
Member

Description

Ensure we wait for all processes before doing the upgrade and don't skip processes in the SidecarUnreachable state. I believe in the long term we want to implement some kind of a ratio to ignore some processes before doing the upgrade (instead of blocking until the issue is resolved).

Type of change

Please select one of the options below.

  • New feature (non-breaking change which adds functionality)

Discussion

See above, we probably want to rethink the upgrade prerequisites to not require all processes being ready to be upgraded but rather a % or fixed number of processes.

Testing

Unit tests + I tested this with the e2e tests to ensure the upgrade is blocked until all processes are "ready" to be upgraded.

Documentation

Follow-up

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 2fd88f8
  • Duration 4:06:14
  • Result: ❌ FAILED
  • Error: Error while executing command: if $(grep -q -- "--- FAIL:" logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" logs/*.log; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

@FoundationDB FoundationDB deleted a comment from sbodagala Nov 30, 2022
@johscheuer johscheuer merged commit f4a5508 into FoundationDB:main Nov 30, 2022
@johscheuer johscheuer deleted the wait-upgrade-processes-ready branch November 30, 2022 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants