If the cluster is upgraded wait for all processes to be ready #1446
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensure we wait for all processes before doing the upgrade and don't skip processes in the
SidecarUnreachable
state. I believe in the long term we want to implement some kind of a ratio to ignore some processes before doing the upgrade (instead of blocking until the issue is resolved).Type of change
Please select one of the options below.
Discussion
See above, we probably want to rethink the upgrade prerequisites to not require all processes being ready to be upgraded but rather a % or fixed number of processes.
Testing
Unit tests + I tested this with the e2e tests to ensure the upgrade is blocked until all processes are "ready" to be upgraded.
Documentation
Follow-up