Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate initial cluster file based on "CoordinatorSelection" #1527

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

sbodagala
Copy link
Contributor

Description

Modify the initial cluster file sub reconciler to make use of the coordinator selection mechanism. And, update the affected tests.

Addresses issue: #1089

Type of change

  • New feature (non-breaking change which adds functionality)

Discussion

  • Does the current operator logic always select storage processes as coordinators? If so, this PR may cause log processes to also be selected as coordinators? And, if so, what is the impact of that during recovery? So, overall, is this a good change?

Testing

Ran the operator unit tests successfully (by doing "make fmt lint test").

Documentation

TBD: Do we need to update any documentation?

Follow-up

@sbodagala sbodagala changed the title Generate initial cluster file based on "CoordinatorSelection" in the cluster spec Generate initial cluster file based on "CoordinatorSelection" Mar 3, 2023
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 230dfc4
  • Duration 2:02:18
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Copy link
Member

@johscheuer johscheuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are doing now more calls to the Kubernetes API (or the local cache), that could be prevented by using a label selector that selects multiple process classes but that would be an optimisation, that is only relevant in the initial cluster create phase so 👍 for the simplicity.

Thanks!

@johscheuer johscheuer merged commit d7376e4 into FoundationDB:main Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants