Ensure we call exclude only on missing processes #1550
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've seen some issues with the frequent calling of the
fdbcli exclude
command to check if a process is excluded from the operator side. We already have logic in the operator code to check if a process is safe to delete (serves no roles) based on the cluster status. The only case where we want to call the exclude command is when the operator has an address that is missing in the cluster status json.Type of change
Please select one of the options below.
Discussion
Most of the code changes are unit tests to ensure we cover all important cases.
Testing
Unit tests and the CI pipeline will run the e2e tests.
Documentation
We don't have a dedicated doc for how the operator handles exclusions, I think it would be a good idea to start a doc in a different PR: #1549.
Follow-up