Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cache client selector #1922

Merged

Conversation

johscheuer
Copy link
Member

Description

Fixes: #985. This will reduce the cached resources to the once that matches the label selector if one is specified.

Type of change

Please select one of the options below.

  • New feature (non-breaking change which adds functionality)

Discussion

Testing

Unit tests + CI will run e2e tests. I will run some additional tests.

Documentation

Follow-up

@johscheuer johscheuer added the enhancement New feature or request label Jan 22, 2024
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 0988288
  • Duration 1:40:31
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Copy link
Member Author

@johscheuer johscheuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are failing because some of the older versions are removed from the CI env. #1923 will fix this.

@johscheuer johscheuer force-pushed the implement-cache-client-selector branch from 0988288 to 14ced6f Compare January 23, 2024 15:29
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 14ced6f
  • Duration 1:46:16
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer johscheuer merged commit fa1d181 into FoundationDB:main Jan 24, 2024
8 checks passed
@johscheuer johscheuer deleted the implement-cache-client-selector branch January 24, 2024 07:57
@gm42
Copy link
Contributor

gm42 commented Feb 28, 2024

@johscheuer I am seeing an odd issue with v1.33.0, which does not reproduce when reverting this change: when creating an empty cluster it fails to get the configmap for the cluster, and then fails to create it (because it actually already exists). Shall I open an issue with more details?

@johscheuer
Copy link
Member Author

@johscheuer I am seeing an odd issue with v1.33.0, which does not reproduce when reverting this change: when creating an empty cluster it fails to get the configmap for the cluster, and then fails to create it (because it actually already exists). Shall I open an issue with more details?

That would be great. Thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement cache client label-selector
5 participants