Fix nil pointer ha e2e

[johscheuer]

Description

We observed the following issue in our nightly test cases:

  [PANICKED] Test Panicked
  In [It] at: /usr/local/go/src/runtime/panic.go:260 @ 02/28/24 13:40:16.976

  runtime error: invalid memory address or nil pointer dereference

  Full Stack Trace
    github.com/FoundationDB/fdb-kubernetes-operator/e2e/fixtures.(*HaFdbCluster).GetCluster(...)
    	/codebuild/output/src3955936553/src/github.com/FoundationDB/fdb-kubernetes-operator/e2e/fixtures/ha_fdb_cluster.go:95
    github.com/FoundationDB/fdb-kubernetes-operator/e2e/fixtures.(*HaFdbCluster).GetPrimary(...)
    	/codebuild/output/src3955936553/src/github.com/FoundationDB/fdb-kubernetes-operator/e2e/fixtures/ha_fdb_cluster.go:54
    github.com/FoundationDB/fdb-kubernetes-operator/e2e/fixtures.(*Factory).CreateFdbHaCluster(0xc000615218?, 0xf91e4ee5dfcf676b?, {0xc000455de0, 0x2, 0x2})
    	/codebuild/output/src3955936553/src/github.com/FoundationDB/fdb-kubernetes-operator/e2e/fixtures/factory.go:198 +0xb7
    github.com/FoundationDB/fdb-kubernetes-operator/e2e/test_operator_ha_upgrades.clusterSetupWithTestConfig({{0xc00004ce60, 0x6}, 0x1, 0x1, 0x1, 0xc0004fb3f0})
    	/codebuild/output/src3955936553/src/github.com/FoundationDB/fdb-kubernetes-operator/e2e/test_operator_ha_upgrades/operator_ha_upgrade_test.go:83 +0x26c
    github.com/FoundationDB/fdb-kubernetes-operator/e2e/test_operator_ha_upgrades.glob..func2.4({0xc00004ce60?, 0x0?}, {0xc00004ce66, 0x6})
    	/codebuild/output/src3955936553/src/github.com/FoundationDB/fdb-kubernetes-operator/e2e/test_operator_ha_upgrades/operator_ha_upgrade_test.go:180 +0x9b
    reflect.Value.call({0x17877c0?, 0x1ad9818?, 0x13?}, {0x19d9e3f, 0x4}, {0xc00057e510, 0x2, 0x2?})
    	/usr/local/go/src/reflect/value.go:586 +0xb0b
    reflect.Value.Call({0x17877c0?, 0x1ad9818?, 0x1c7d818?}, {0xc00057e510?, 0x430f8290b0bcbfd9?, 0xe7557fe55be6e393?})
    	/usr/local/go/src/reflect/value.go:370 +0xbc

  There were additional failures detected.  To view them in detail run ginkgo -vv

The issue was that the returned error was checked after the method was accessing the returned pointer.

Type of change

Please select one of the options below.

• Bug fix (non-breaking change which fixes an issue)

Discussion

Testing

CI will be running tests.

Documentation

Follow-up

[foundationdb-ci]

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

• Commit ID: d447141
• Duration 2:00:11
• Result: ❌ FAILED
• Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

• Commit ID: d447141
• Duration 2:04:28
• Result: ✅ SUCCEEDED
• Error: N/A
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[nicmorales9]

LGTM