Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor typo fix in mention of localities #1957

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Conversation

gm42
Copy link
Contributor

@gm42 gm42 commented Mar 5, 2024

Description

This is a minor typo fix in the documentation (technical design).

Type of change

  • Documentation

@johscheuer johscheuer added the documentation Improvements or additions to documentation label Mar 5, 2024
Copy link
Member

@johscheuer johscheuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

docs/manual/technical_design.md Outdated Show resolved Hide resolved
Copy link
Member

@johscheuer johscheuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@johscheuer johscheuer merged commit f150c0a into FoundationDB:main Mar 6, 2024
7 checks passed
@gm42
Copy link
Contributor Author

gm42 commented Mar 6, 2024

Thanks @johscheuer!

I have a related question: I am creating a cluster using the faultDomain as described here. I copy/pasted that block in my FDB definition, even if documentation mentions that it is the default and thus should be unnecessary.

However pods are still getting scheduled on same nodes, and I do not see any topology spread / pod anti-affinity being generated in the pod YAML definitions created by the operator. I also tried to find references to this configuration in the codebase of the operator, but I can't find anything related to the default as mentioned there 🤔 instead I see plenty of checks for the key foundationdb.org/kubernetes-cluster.

Do you have any pointers for me to understand better how the fault domain feature works, or perhaps existing E2E tests covering this?

@johscheuer
Copy link
Member

Could you create an issue or a forum post for that? Tracking all the comments/question in unrelated PR's makes it harder for me to make sure I answered your questions.

The best is to always produce a minimal reproducible example.

@gm42
Copy link
Contributor Author

gm42 commented Mar 7, 2024

Sure, I wanted to make sure that there is a problem first, by checking the relevant code. I will try to reproduce it and then open an issue.

@gm42
Copy link
Contributor Author

gm42 commented Mar 7, 2024

Figured a few things out, the issue is open here.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants