Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more addresses to be present in the upgrade bounce case #1960

Conversation

johscheuer
Copy link
Member

Description

We have seen a case in our nightly runs where one process was marked for removal but not yet fully excluded. I believe in such cases it's fine to have more addresses than the expected list, as it could take a while until a process is fully excluded,

Type of change

Please select one of the options below.

  • Bug fix (non-breaking change which fixes an issue)

Discussion

Testing

Ran unit tests and CI will run e2e tests.

Documentation

Follow-up

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 1a2df77
  • Duration 2:01:20
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Copy link
Contributor

@nicmorales9 nicmorales9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

controllers/bounce_processes.go Outdated Show resolved Hide resolved
Co-authored-by: nicmorales9 <153320946+nicmorales9@users.noreply.github.com>
Copy link
Member Author

@johscheuer johscheuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merge the PR as the PR comment was only a typo fix.

@johscheuer johscheuer merged commit 443ffac into FoundationDB:main Mar 11, 2024
7 checks passed
@johscheuer johscheuer deleted the allow-more-than-expected-processes-in-upgrade-case branch March 11, 2024 10:47
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 4af6c6d
  • Duration 2:05:37
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants