-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make use of unstructured when using SSA to prevent default values causing issues #1962
Merged
johscheuer
merged 3 commits into
FoundationDB:main
from
johscheuer:make-ssa-more-reliable
Jun 25, 2024
Merged
Make use of unstructured when using SSA to prevent default values causing issues #1962
johscheuer
merged 3 commits into
FoundationDB:main
from
johscheuer:make-ssa-more-reliable
Jun 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
nicmorales9
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks good if it works in testing, though it'd be good to get clarification on the forceOwnership thread.
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
johscheuer
force-pushed
the
make-ssa-more-reliable
branch
from
March 21, 2024 08:12
e9b2463
to
7986aa4
Compare
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
johscheuer
force-pushed
the
make-ssa-more-reliable
branch
from
June 6, 2024 07:44
7986aa4
to
98a5127
Compare
johscheuer
commented
Jun 6, 2024
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
nicmorales9
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks right to me
…uite randomly with server side apply enabled or disabled
johscheuer
force-pushed
the
make-ssa-more-reliable
branch
from
June 24, 2024 08:34
98a5127
to
fb51b25
Compare
johscheuer
commented
Jun 24, 2024
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There have been some issues in the past when we tested SSA in the current implementation with default values and it's also a known issue with the controller-runtime, e.g.: kubernetes-sigs/controller-runtime#1669 (only to link one issue).
Type of change
Please select one of the options below.
Discussion
This will add some more cpu cycles to the operator when pushing the patch but I think this is the simplest way to approach this issue right now. Once the controller-runtime has a better approach we can remove this workaround.
Testing
Ran a manual e2e test.
CI will run all e2e tests with the SSA feature as I enabled it in the operator deployment.
Documentation
Follow-up