Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report correct current uptime in log line for safe bounce check #1974

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

gm42
Copy link
Contributor

@gm42 gm42 commented Mar 19, 2024

Description

The log line for the bounce check does not report the current uptime.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Discussion

Is it okay to leave the imports change, or do you prefer me to undo that?

Testing

Pre-existing test has been updated.

Documentation

No changes needed.

Follow-up

No follow-up needed.

Copy link
Member

@johscheuer johscheuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks!

Copy link
Member

@johscheuer johscheuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I skip the e2e test as the error message was only updated.

@johscheuer johscheuer merged commit 5b3720b into FoundationDB:main Mar 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants