Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label selection for pods/processGroups #1981

Merged
merged 4 commits into from
Apr 9, 2024

Conversation

nicmorales9
Copy link
Contributor

@nicmorales9 nicmorales9 commented Apr 3, 2024

Description

This PR adds the ability to select pods/processGroups by label selection. This still requires a cluster name to be provided as I felt that would reduce the risk of accidental selection.
It also improves the error message of the cordon command for when no pods are found to be running on a node.

This solves #597

Type of change

Please select one of the options below.

  • New feature (non-breaking change which adds functionality)

Discussion

Are there any design details that you would like to discuss further?

Testing

t

Documentation

Did you update relevant documentation within this repository?

If this change is adding new functionality, do we need to describe it in our user manual?

If this change is adding or removing subreconcilers, have we updated the core technical design doc to reflect that?

If this change is adding new safety checks or new potential failure modes, have we documented and how to debug potential issues?

Follow-up

Are there any follow-up issues that we should pursue in the future?

Does this introduce new defaults that we should re-evaluate in the future?

@nicmorales9 nicmorales9 changed the title Label select Label selection for pods/processGroups Apr 3, 2024
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 82caec8
  • Duration 0:05:09
  • Result: ❌ FAILED
  • Error: reference not found for primary source and source version 82caec84ebc61755b1d99f3b128916fa6ad70426
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 3d2ece0
  • Duration 2:07:57
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@nicmorales9 nicmorales9 changed the title Label selection for pods/processGroups WIP: Label selection for pods/processGroups Apr 4, 2024
@nicmorales9 nicmorales9 changed the title WIP: Label selection for pods/processGroups Label selection for pods/processGroups Apr 4, 2024
@nicmorales9
Copy link
Contributor Author

Github doesn't want me to edit the comment today but for testing:
Unit tests were added, and I tested all the process selection commands manually. I also ensured that cordon is still working fine since it has some overlapping functions.

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 3f7e304
  • Duration 2:20:06
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 93750e7
  • Duration 2:26:47
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Copy link
Member

@brownleej brownleej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@johscheuer johscheuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks! As a next step we should remove the useProcessGroupID option.

kubectl-fdb/cmd/k8s_client.go Outdated Show resolved Hide resolved
kubectl-fdb/cmd/k8s_client.go Outdated Show resolved Hide resolved
kubectl-fdb/cmd/k8s_client.go Outdated Show resolved Hide resolved
@johscheuer johscheuer merged commit a0194d0 into FoundationDB:main Apr 9, 2024
7 of 8 checks passed
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 3812ae7
  • Duration 2:18:37
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants