Automatically add port for backup and restore #1985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
johscheuer
requested changes
Apr 11, 2024
There was a problem hiding this comment.
Can we update the docs for backups: https://github.com/FoundationDB/fdb-kubernetes-operator/blob/main/docs/manual/backup.md with the new behaviour?
|
Merging as the e2e tests are not covering the backup setup yet. |
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a default port, 443 unless secure_connection is set to 0 (in which case, it will default to port 80) as described here https://apple.github.io/foundationdb/backups.html#backup-urls
As described in the issue, a port is required by FDB backup/restore, so this should not be breaking.
Solves #1240
Type of change
Depends who you ask
Discussion
Are there any design details that you would like to discuss further?
Testing
Please describe the tests that you ran to verify your changes. Unit tests?
Manual testing?
Unit tests
Do we need to perform additional testing once this is merged, or perform in a larger testing environment?
Unsure
Documentation
Did you update relevant documentation within this repository?
I believe so
If this change is adding new functionality, do we need to describe it in our user manual?
No?
Follow-up
Are there any follow-up issues that we should pursue in the future?
Does this introduce new defaults that we should re-evaluate in the future?
I do not think they are of concern