Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the limitation that only custom parameters for fdbserver can be defined #1988

Conversation

johscheuer
Copy link
Member

Description

Fixes: #1976

Type of change

Please select one of the options below.

  • Bug fix (non-breaking change which fixes an issue)

Discussion

As long as we are not supporting to set those general parameters we should make sure that the operator rejects those.

Testing

Added unit tests.

Documentation

Updated.

Follow-up

We have to clarify if there is a need to set those parameters.

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 13337f0
  • Duration 2:15:30
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Copy link
Contributor

@nicmorales9 nicmorales9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johscheuer johscheuer merged commit b62be51 into FoundationDB:main Apr 15, 2024
8 checks passed
@johscheuer johscheuer deleted the add-additional-checks-custom-parameters branch April 15, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using a restart_delay override creates a cluster with a persistent IncorrectProcess reconciliation problem
3 participants