Correct log line for maintenance check and remove process if restarted in different zone

[johscheuer]

Description

Only log Cluster in maintenance mode if the maintenance zone is actually set. Allow the operator to remove processes that are restarted from the underMaintenance list, even if they are running in a different zone. For clusters using disaggregated storage this could happen.

Type of change

Please select one of the options below.

• Bug fix (non-breaking change which fixes an issue)

Discussion

Testing

Ran manual e2e tests.

Documentation

Follow-up

[foundationdb-ci]

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

• Commit ID: 40741ed
• Duration 2:21:45
• Result: ❌ FAILED
• Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[johscheuer]

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

• Commit ID: 40741ed
• Duration 2:21:45
• Result: ❌ FAILED
• Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[Container] 2024/04/16 18:21:11.483570 Running command if $(grep -q -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/logs/*.log; export fail_test=true; fi
TESTS FAILED SEE THESE LOGS:

/codebuild/output/src1707588491/src/github.com/FoundationDB/fdb-kubernetes-operator/logs/test_operator_ha_upgrades.log

The failing test is not related to those changes:

Summarizing 1 Failure:
  [FAIL] Operator HA Upgrades when no remote storage processes are restarted [It] Upgrade from 7.1.57 to 7.3.33 [e2e, pr]
  /codebuild/output/src1707588491/src/github.com/FoundationDB/fdb-kubernetes-operator/e2e/fixtures/ha_fdb_cluster.go:313