Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small logging improvements and code restructure for the taint feature #1993

Merged

Conversation

johscheuer
Copy link
Member

Description

Changes to correct the logged fields and make sure we use a consistent set of fields in the logger.

Type of change

Please select one of the options below.

  • Bug fix (non-breaking change which fixes an issue)

Discussion

I labeled this as a bug as some logged values used the wrong "format".

Testing

Ran unit tests and CI will run e2e tests.

Documentation

Follow-up

@johscheuer johscheuer added the bug Something isn't working label Apr 16, 2024
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: e53f8d3
  • Duration 2:16:03
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer johscheuer closed this Apr 17, 2024
@johscheuer johscheuer reopened this Apr 17, 2024
@johscheuer johscheuer closed this Apr 17, 2024
@johscheuer johscheuer reopened this Apr 17, 2024
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: e53f8d3
  • Duration 2:13:56
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: e53f8d3
  • Duration 2:14:24
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Copy link
Contributor

@nicmorales9 nicmorales9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I assume there are pre-existing tests covering this feature?

@johscheuer johscheuer merged commit 8cb954b into FoundationDB:main Apr 17, 2024
22 checks passed
@johscheuer johscheuer deleted the fix-smaller-bugx-replacement-logs branch April 17, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants