Limit range over processes to DC

[nicmorales9]

Description

This PR addresses #1264
It has a comment on every location (outside of e2e test code) that uses status.Cluster.Processes with reasoning explanations if it was not isolated to a single DC. This is for the ease of review, I will remove the comments after my logic is checked over.

Type of change

• feature/ optimization?

Discussion

Are there any design details that you would like to discuss further?

Testing

t
Please describe the tests that you ran to verify your changes. Unit tests?
Manual testing?

Do we need to perform additional testing once this is merged, or perform in a larger testing environment?

Documentation

Did you update relevant documentation within this repository?

If this change is adding new functionality, do we need to describe it in our user manual?

If this change is adding or removing subreconcilers, have we updated the core technical design doc to reflect that?

If this change is adding new safety checks or new potential failure modes, have we documented and how to debug potential issues?

Follow-up

Are there any follow-up issues that we should pursue in the future?

Does this introduce new defaults that we should re-evaluate in the future?

[foundationdb-ci]

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

• Commit ID: c440156
• Duration 2:59:35
• Result: ❌ FAILED
• Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

• Commit ID: 73efaf7
• Duration 2:54:29
• Result: ❌ FAILED
• Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

• Commit ID: 73efaf7
• Duration 3:02:57
• Result: ❌ FAILED
• Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[johscheuer]

Changes LGTM 👍

[foundationdb-ci]

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

• Commit ID: 73efaf7
• Duration 3:05:57
• Result: ❌ FAILED
• Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

• Commit ID: 73efaf7
• Duration 2:56:18
• Result: ❌ FAILED
• Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

• Commit ID: 73efaf7
• Duration 2:53:09
• Result: ❌ FAILED
• Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

• Commit ID: 23221bd
• Duration 2:47:02
• Result: ❌ FAILED
• Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

• Commit ID: 370adec
• Duration 0:02:45
• Result: ❌ FAILED
• Error: Error while executing command: IMG=${REGISTRY}/${OPERATOR_IMAGE} make container-build container-push. Reason: exit status 2
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[nicmorales9]

Failures looked unrelated to changes

[foundationdb-ci]

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

• Commit ID: 370adec
• Duration 0:02:46
• Result: ❌ FAILED
• Error: Error while executing command: IMG=${REGISTRY}/${OPERATOR_IMAGE} make container-build container-push. Reason: exit status 2
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

• Commit ID: 370adec
• Duration 0:02:56
• Result: ❌ FAILED
• Error: Error while executing command: IMG=${REGISTRY}/${OPERATOR_IMAGE} make container-build container-push. Reason: exit status 2
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

• Commit ID: 8a3d845
• Duration 2:18:45
• Result: ❌ FAILED
• Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[johscheuer]

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

• Commit ID: 8a3d845
• Duration 2:18:45
• Result: ❌ FAILED
• Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

 2024/04/23 17:21:33 reconciled name=fdb-cluster-w8wk6p64, namespace=pr-796-a6s7rpch, generation:101
• [FAILED] [133.078 seconds]
Operator when the operator is allowed to reset the maintenance zone [BeforeEach] should reset the maintenance mode once the Pod was restarted [e2e, pr]
  [BeforeEach] /codebuild/output/src389058347/src/github.com/FoundationDB/fdb-kubernetes-operator/e2e/test_operator/operator_test.go:2029
  [It] /codebuild/output/src389058347/src/github.com/FoundationDB/fdb-kubernetes-operator/e2e/test_operator/operator_test.go:2059

  [FAILED] Timed out after 120.001s.
  Unexpected error:
      <exec.CodeExitError>: 
      command terminated with exit code 2
      {
          Err: <*errors.errorString | 0xc00020bbb0>{
              s: "command terminated with exit code 2",
          },
          Code: 2,
      }
  occurred
  In [BeforeEach] at: /codebuild/output/src389058347/src/github.com/FoundationDB/fdb-kubernetes-operator/e2e/fixtures/status.go:79 @ 04/23/24 17:21:31.973
------------------------------

That failure is unrelated and I'm going to create an issue to track that down.