Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure that only the container is build #2005

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Make sure that only the container is build #2005

merged 1 commit into from
Apr 23, 2024

Conversation

johscheuer
Copy link
Member

@johscheuer johscheuer commented Apr 23, 2024 •
edited

Description

If the container-build target is used, we don't want to build everything, as the build container will take care of that.

Type of change

Please select one of the options below.

  • Bug fix (non-breaking change which fixes an issue)

Discussion

This is a relict from the past when we didn't use the multi-stage build.

Testing

CI pipeline is running.

Documentation

Follow-up

@johscheuer johscheuer added the bug Something isn't working label Apr 23, 2024
@johscheuer johscheuer marked this pull request as ready for review April 23, 2024 11:48
@johscheuer johscheuer changed the title Make sure tha tonly the container is build Make sure that only the container is build Apr 23, 2024
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 2fedded
  • Duration 2:20:30
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer johscheuer merged commit d25f068 into FoundationDB:main Apr 23, 2024
7 of 8 checks passed
@johscheuer johscheuer deleted the only-build-container branch April 23, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicmorales9 nicmorales9 nicmorales9 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@johscheuer @foundationdb-ci @nicmorales9