Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure we ignore clients that share the same machine address as a process from the FoundationDB cluster #2022

Conversation

johscheuer
Copy link
Member

Description

Fixes: #1991

Type of change

Please select one of the options below.

  • Bug fix (non-breaking change which fixes an issue)

Discussion

We can ignore clients that share the same machine address as the FoundationDB processes. In most (if not all) cases that will be an fdbcli command that was manually ran to e.g. get the cluster status.

Testing

Updated the unit tests and CI will run e2e tests.

Documentation

Follow-up

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 9df899d
  • Duration 2:35:49
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer johscheuer force-pushed the ignore-processes-compatibility-check-running-on-same-fdb-pod branch from 9df899d to 365cbf1 Compare May 14, 2024 15:36
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 365cbf1
  • Duration 2:31:11
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Copy link
Contributor

@nicmorales9 nicmorales9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

api/v1beta2/foundationdb_status.go Show resolved Hide resolved
@johscheuer johscheuer merged commit e36e605 into FoundationDB:main May 21, 2024
8 checks passed
@johscheuer johscheuer deleted the ignore-processes-compatibility-check-running-on-same-fdb-pod branch May 21, 2024 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deferring reconciliation due to unsupported clients (coordinators)
3 participants