Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support for the unified image in the backup deployment #2025

Merged

Conversation

johscheuer
Copy link
Member

Description

Fixes: #1030

Type of change

Please select one of the options below.

  • New feature (non-breaking change which adds functionality)

Discussion

Adds support for using the unified image in the backup deployment. Even thought the current implementation of backups are not using any features of the monitor.

Testing

Will be done manually.

Documentation

Follow-up

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 7fca252
  • Duration 2:19:08
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

internal/pod_models.go Outdated Show resolved Hide resolved
@johscheuer johscheuer marked this pull request as ready for review May 15, 2024 11:05
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 607380b
  • Duration 2:43:06
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Copy link
Contributor

@nicmorales9 nicmorales9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

internal/pod_models.go Outdated Show resolved Hide resolved
@johscheuer johscheuer merged commit b407f61 into FoundationDB:main May 17, 2024
7 checks passed
@johscheuer johscheuer deleted the initial-support-unified-image-backup branch May 17, 2024 14:55
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: b012cb0
  • Duration 2:28:18
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supporting the new unified image in the backup pods
3 participants