Fix DNS setup for unified image and make sure env variable is set

[johscheuer]

Description

Fix DNS setup for unified image and make sure env variable is set

Type of change

Please select one of the options below.

• Bug fix (non-breaking change which fixes an issue)

Discussion

Testing

Ran the DNS related e2e tests manually:

Coordination servers:
  jdev-log-10.jdev.jscheuermann.svc.cluster.local:4500:tls  (reachable)
  jdev-log-6.jdev.jscheuermann.svc.cluster.local:4500:tls  (reachable)
  jdev-log-7.jdev.jscheuermann.svc.cluster.local:4500:tls  (reachable)
  jdev-log-8.jdev.jscheuermann.svc.cluster.local:4500:tls  (reachable)
  jdev-log-9.jdev.jscheuermann.svc.cluster.local:4500:tls  (reachable)

Client time: 05/17/24 15:35:55

Test output:

------------------------------
[AfterSuite]
/Users/jscheuermann/go/src/github.com/FoundationDB/fdb-kubernetes-operator/e2e/test_operator/operator_test.go:97
[AfterSuite] PASSED [0.000 seconds]
------------------------------
[ReportAfterSuite] Autogenerated ReportAfterSuite for --junit-report
autogenerated by Ginkgo
[ReportAfterSuite] PASSED [0.006 seconds]
------------------------------

Ran 1 of 48 Specs in 635.390 seconds
SUCCESS! -- 1 Passed | 0 Failed | 9 Pending | 38 Skipped

Documentation

Follow-up

[foundationdb-ci]

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

• Commit ID: 2611904
• Duration 2:16:48
• Result: ✅ SUCCEEDED
• Error: N/A
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[nicmorales9]

LGTM! (Assuming that cluster.DefineDNSLocalityFields() is never true when version.SupportsDNSInClusterFile is false)

[johscheuer]

LGTM! (Assuming that cluster.DefineDNSLocalityFields() is never true when version.SupportsDNSInClusterFile is false)

DefineDNSLocalityFields can be true when SupportsDNSInClusterFile is false. In this case the connection string would still use IP addresses but the locality fields for the DNS name will be present.