Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for env variables in custom parameters for the unified image #2035

Merged

Conversation

johscheuer
Copy link
Member

Description

Fixes: #1032

Type of change

Please select one of the options below.

  • Bug fix (non-breaking change which fixes an issue)

Discussion

Testing

Added a new test and ran it with the unified image.

Documentation

Follow-up

@johscheuer johscheuer added the bug Something isn't working label May 22, 2024
Copy link
Member Author

@johscheuer johscheuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test results from the manual run:

------------------------------
SSSSSSSSSS
------------------------------
Operator when setting a locality that is using an environment variable should update the locality with the substituted environment variable [e2e, pr]
/Users/jscheuermann/go/src/github.com/FoundationDB/fdb-kubernetes-operator/e2e/test_operator/operator_test.go:2179
  2024/05/22 19:21:31 UpdateClusterSpec: specUpdated: false
  2024/05/22 19:21:32 UpdateClusterSpec: specUpdated: true
  2024/05/22 19:21:39 UpdateClusterSpec: specUpdated: false
  2024/05/22 19:21:41 UpdateClusterSpec: specUpdated: true
  2024/05/22 19:21:41 waiting until the cluster jscheuermann/jdev is healthy and reconciled
  2024/05/22 19:24:21 reconciled name=jdev, namespace=jscheuermann, generation:3
  2024/05/22 19:24:21 waiting until the cluster jscheuermann/jdev is healthy and reconciled
  2024/05/22 19:24:22 reconciled name=jdev, namespace=jscheuermann, generation:3
• [203.776 seconds]
------------------------------
[AfterSuite]
/Users/jscheuermann/go/src/github.com/FoundationDB/fdb-kubernetes-operator/e2e/test_operator/operator_test.go:97
[AfterSuite] PASSED [0.000 seconds]
------------------------------
[ReportAfterSuite] Autogenerated ReportAfterSuite for --junit-report
autogenerated by Ginkgo
[ReportAfterSuite] PASSED [0.005 seconds]
------------------------------

Ran 1 of 50 Specs in 440.161 seconds
SUCCESS! -- 1 Passed | 0 Failed | 9 Pending | 40 Skipped
PASS | FOCUSED
FAIL    github.com/FoundationDB/fdb-kubernetes-operator/e2e/test_operator       440.621s
FAIL

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 5ee0e4b
  • Duration 2:26:09
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 8e28316
  • Duration 2:23:36
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Copy link
Contributor

@nicmorales9 nicmorales9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johscheuer johscheuer merged commit 4177154 into FoundationDB:main May 23, 2024
8 checks passed
@johscheuer johscheuer deleted the allow-custom-parameter-env-vars branch May 23, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supporting substitutions in custom parameters in the unified image
3 participants