Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to override the image tag for specific versions #2037

Merged

Conversation

johscheuer
Copy link
Member

Description

Adding support to override the image tag for specific FDB versions. This can be useful if someone want to run the e2e test suite with a custom set of images.

Type of change

Please select one of the options below.

  • New feature (non-breaking change which adds functionality)

Discussion

Testing

Ran manually an upgrade test for the unified image.

Documentation

Added in the makefile.

Follow-up

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 754c748
  • Duration 0:10:41
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 0809552
  • Duration 2:40:24
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Copy link
Contributor

@nicmorales9 nicmorales9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me!

@johscheuer johscheuer merged commit b0f37ab into FoundationDB:main May 28, 2024
8 checks passed
@johscheuer johscheuer deleted the allow-override-image-tag-version branch May 28, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants