Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the same ConfigMap entries for all different process configuration #2038

Merged

Conversation

johscheuer
Copy link
Member

Description

Fixes: #1033

Type of change

Please select one of the options below.

  • New feature (non-breaking change which adds functionality)

Discussion

This removes the need to maintain different ConfigMap entries for different server counts, in the case of the unified image, this will be handled by the fdb-kubernetes-monitor based on the start arguments.

Testing

Ran manual e2e test with the unified image.

Documentation

Follow-up

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 22e42b6
  • Duration 2:24:43
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer johscheuer force-pushed the unified-image-unify-configmap branch from 5546dac to 936119f Compare May 24, 2024 12:16
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 5546dac
  • Duration 3:06:47
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 936119f
  • Duration 2:47:50
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Copy link
Contributor

@nicmorales9 nicmorales9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

internal/monitor_conf.go Outdated Show resolved Hide resolved
Co-authored-by: nicmorales9 <153320946+nicmorales9@users.noreply.github.com>
@johscheuer johscheuer merged commit 1dd6a24 into FoundationDB:main Jun 3, 2024
7 checks passed
@johscheuer johscheuer deleted the unified-image-unify-configmap branch June 3, 2024 12:37
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 90bbe98
  • Duration 3:09:29
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using the same monitor conf for different storage server densities on the new image
3 participants