Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the node watch feature from the unified image #2040

Merged

Conversation

johscheuer
Copy link
Member

Description

Blocked on apple/foundationdb#11431

Fixes: #2039

Type of change

Please select one of the options below.

  • New feature (non-breaking change which adds functionality)

Discussion

Testing

I will do some additional testing before merging.

Documentation

I added some documentation for this feature in the cluster spec. I'll create an issue to update the fault_domain docs with this new feature.

Follow-up

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 6540a12
  • Duration 2:27:42
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

api/v1beta2/foundationdbcluster_types.go Outdated Show resolved Hide resolved
@johscheuer johscheuer force-pushed the add-support-unified-image-node-watch branch from 6540a12 to 41b78e3 Compare June 14, 2024 11:21
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 41b78e3
  • Duration 2:51:21
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer johscheuer force-pushed the add-support-unified-image-node-watch branch from 1034525 to 691acc3 Compare June 14, 2024 14:42
@johscheuer johscheuer merged commit 0a27ceb into FoundationDB:main Jun 14, 2024
7 of 8 checks passed
@johscheuer johscheuer deleted the add-support-unified-image-node-watch branch June 14, 2024 15:13
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 1034525
  • Duration 3:13:33
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 691acc3
  • Duration 3:21:30
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow the operator to make use of node labels in fault domains
3 participants