Change the useUnifiedImage setting to a more generic imageType

[johscheuer]

Description

Following the best practices from: https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#primitive-types

Type of change

• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Discussion

This is a breaking change but since the feature is currently not usable I think it's fine to change it anyways. We should make sure to announce it in the release notes but from my point of view the risk is minimal as we haven't released the unified image yet.

Testing

Unit tests.

Documentation

Follow-up

[foundationdb-ci]

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

• Commit ID: 3c70687
• Duration 2:32:40
• Result: ❌ FAILED
• Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

• Commit ID: 9328946
• Duration 2:50:57
• Result: ❌ FAILED
• Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

• Commit ID: b0c09c4
• Duration 2:54:06
• Result: ❌ FAILED
• Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[johscheuer]

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

• Commit ID: b0c09c4
• Duration 2:54:06
• Result: ❌ FAILED
• Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

  2024/05/28 15:25:16 finished all tests, start deleting namespace pr-865-vrtxhka6
• [FAILED] [376.722 seconds]
Operator Upgrades upgrading a cluster with a crash looping sidecar process [It] Upgrade from 7.1.57 to 7.3.33 with crash-looping sidecar [e2e, pr]
/codebuild/output/src1815370707/src/github.com/FoundationDB/fdb-kubernetes-operator/e2e/fixtures/upgrade_test_configuration.go:115

  [FAILED] Timed out after 120.000s.
  There is no failure as the matcher passed to Eventually succeeded on its most recent iteration
  In [It] at: /codebuild/output/src1815370707/src/github.com/FoundationDB/fdb-kubernetes-operator/e2e/test_operator_upgrades/operator_upgrades_test.go:271 @ 05/28/24 15:25:01.142
-----------------------------

🤔

[foundationdb-ci]

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

• Commit ID: 3c70687
• Duration 2:02:29
• Result: ❌ FAILED
• Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[johscheuer]

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

• Commit ID: 3c70687
• Duration 2:02:29
• Result: ❌ FAILED
• Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

Summarizing 1 Failure:
  [FAIL] Operator HA Upgrades when no remote storage processes are restarted [It] Upgrade from 7.1.57 to 7.3.33 [e2e, pr]
  /codebuild/output/src1309749207/src/github.com/FoundationDB/fdb-kubernetes-operator/e2e/fixtures/ha_fdb_cluster.go:313

Seems unrelated 🤔

[nicmorales9]

LGTM! I've also seen that e2e test fail sometimes, do we have an issue for it?

[johscheuer]

LGTM! I've also seen that e2e test fail sometimes, do we have an issue for it?

We have a few issues open for some test flakiness. In general some tests are failing because some of the test requirements are fairly strict and the EKS test setup can be a bit flaky if a lot of tests run concurrently.

[foundationdb-ci]

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

• Commit ID: b95b891
• Duration 2:13:18
• Result: ❌ FAILED
• Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

• Commit ID: b95b891
• Duration 2:15:42
• Result: ✅ SUCCEEDED
• Error: N/A
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)