-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the useUnifiedImage setting to a more generic imageType #2042
Change the useUnifiedImage setting to a more generic imageType #2042
Conversation
9328946
to
3c70687
Compare
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
🤔 |
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
Seems unrelated 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I've also seen that e2e test fail sometimes, do we have an issue for it?
3c70687
to
b95b891
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I've also seen that e2e test fail sometimes, do we have an issue for it?
We have a few issues open for some test flakiness. In general some tests are failing because some of the test requirements are fairly strict and the EKS test setup can be a bit flaky if a lot of tests run concurrently.
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
Description
Following the best practices from: https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#primitive-types
Type of change
Discussion
This is a breaking change but since the feature is currently not usable I think it's fine to change it anyways. We should make sure to announce it in the release notes but from my point of view the risk is minimal as we haven't released the unified image yet.
Testing
Unit tests.
Documentation
Follow-up