Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor replacement tests for better readability #2044

Merged

Conversation

johscheuer
Copy link
Member

Description

The previous setup had some weird interactions with JustBeforeEach and was hard to read.

Type of change

  • Other

Discussion

Testing

Ran the unit tests, since we only changed tests, there is no need for running the e2e tests.

Documentation

Follow-up

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 5dd6824
  • Duration 2:15:21
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Copy link
Contributor

@nicmorales9 nicmorales9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

internal/replacements/replacements_test.go Show resolved Hide resolved
internal/replacements/replacements_test.go Show resolved Hide resolved
Copy link
Member Author

@johscheuer johscheuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging and the code changes are not touching anything outside the test code. So there is no need to wait for the e2e tests to finish.

@johscheuer johscheuer merged commit d37fe4e into FoundationDB:main Jun 3, 2024
7 of 8 checks passed
@johscheuer johscheuer deleted the refactor-replacement-test-suite branch June 3, 2024 13:25
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 5a28a28
  • Duration 2:49:25
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants