Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer processes in coordinator selection for multi-region clusters #2045

Conversation

johscheuer
Copy link
Member

Description

Fixes: #2034

Type of change

Please select one of the options below.

  • New feature (non-breaking change which adds functionality)

Discussion

Most of the code changes are adjustments for the testing code, to make sure we add some randomness.

Testing

Added additional unit tests and modified them.

Documentation

Follow-up

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 93cce33
  • Duration 2:57:28
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer johscheuer closed this Jun 4, 2024
@johscheuer johscheuer reopened this Jun 4, 2024
Copy link
Member Author

@johscheuer johscheuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new benchmark will present a result like this:

------------------------------
• [0.035 seconds]
Localities chooseDistributedProcesses when a multi-region cluster is used with 4 dcs when measuring the performance for choose distributed processes [measurement]
/Users/jscheuermann/go/src/github.com/FoundationDB/fdb-kubernetes-operator/internal/locality/locality_test.go:630

  Report Entries >>
  Choose Distributed Processes - /Users/jscheuermann/go/src/github.com/FoundationDB/fdb-kubernetes-operator/internal/locality/locality_test.go:636 @ 06/04/24 11:52:09.548
    Choose Distributed Processes
    Name                                  | N  | Min   | Median | Mean  | StdDev | Max
    ==================================================================================
    ChooseDistributedProcesses [duration] | 50 | 300µs | 400µs  | 400µs | 100µs  | 1ms

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 93cce33
  • Duration 2:25:22
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: a197e87
  • Duration 2:30:20
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 0b9b6aa
  • Duration 2:25:00
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: b615ff2
  • Duration 2:12:55
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Copy link
Contributor

@nicmorales9 nicmorales9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few things to double check but the core lgtm

internal/locality/locality_test.go Show resolved Hide resolved
internal/locality/locality_test.go Show resolved Hide resolved
@johscheuer johscheuer merged commit 3eb8c7d into FoundationDB:main Jun 4, 2024
7 of 8 checks passed
@johscheuer johscheuer deleted the prefer-primary-coordinator-selection-multi-region branch June 4, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coordinator selection should prefer primary
3 participants