Unified image code clean up and make use of the same constant #2051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicmorales9
approved these changes
Jun 5, 2024
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #2043
Type of change
Please select one of the options below.
Discussion
We changed the disk layout with the unified image, if only a single storage server per pod is used, then the data directory is still suffixed with
/1. This would break the transition to the unified image for cluster with a single storage server per pod.I also made sure we remove some internal method duplications.
Testing
Updated the unit tests and CI will run e2e tests.
Documentation
Follow-up