-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix e2e upgrade tests with chaos for unified image #2057
Merged
johscheuer
merged 3 commits into
FoundationDB:main
from
johscheuer:fix-e2e-chaos-tests-with-unified-image
Jun 11, 2024
Merged
Fix e2e upgrade tests with chaos for unified image #2057
johscheuer
merged 3 commits into
FoundationDB:main
from
johscheuer:fix-e2e-chaos-tests-with-unified-image
Jun 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
nicmorales9
approved these changes
Jun 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks good, some nits and questions for my understanding though
e2e/test_operator_upgrades_with_chaos/operator_upgrades_with_chaos_test.go
Show resolved
Hide resolved
johscheuer
commented
Jun 11, 2024
Merging as I only removed an old comment. |
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some of the e2e upgrade tests with chaos had some assumption that were only true for the split image approach.
Type of change
Please select one of the options below.
Discussion
Testing
I ran those tests manually with the fix from #2056.
Documentation
Follow-up