Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e upgrade tests with chaos for unified image #2057

Merged

Conversation

johscheuer
Copy link
Member

Description

Some of the e2e upgrade tests with chaos had some assumption that were only true for the split image approach.

Type of change

Please select one of the options below.

  • Bug fix (non-breaking change which fixes an issue)

Discussion

Testing

I ran those tests manually with the fix from #2056.

Documentation

Follow-up

@johscheuer johscheuer added the bug Something isn't working label Jun 10, 2024
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 9c427a1
  • Duration 2:44:51
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer johscheuer closed this Jun 10, 2024
@johscheuer johscheuer reopened this Jun 10, 2024
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 9c427a1
  • Duration 2:40:44
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Copy link
Contributor

@nicmorales9 nicmorales9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good, some nits and questions for my understanding though

@johscheuer
Copy link
Member Author

Merging as I only removed an old comment.

@johscheuer johscheuer merged commit fc2f8d2 into FoundationDB:main Jun 11, 2024
7 checks passed
@johscheuer johscheuer deleted the fix-e2e-chaos-tests-with-unified-image branch June 11, 2024 13:50
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 90871c0
  • Duration 2:43:10
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants