-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document the delay shutdown feature and check in update Pods if pod is missing #2065
Conversation
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
70eb4b9
to
b057f2a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, though the PR name should reflect that non-documentation changes are going in, and it would be nice to have a test showing the logic when it's been over 90s since the condition time was set
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test looks good
Description
Fixes: #1876
Type of change
Discussion
Testing
Documentation
Updated.
Follow-up