Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the delay shutdown feature and check in update Pods if pod is missing #2065

Merged
merged 3 commits into from
Jun 28, 2024

Conversation

johscheuer
Copy link
Member

Description

Fixes: #1876

Type of change

  • Documentation

Discussion

Testing

Documentation

Updated.

Follow-up

@johscheuer johscheuer added the documentation Improvements or additions to documentation label Jun 17, 2024
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 70eb4b9
  • Duration 3:18:18
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Copy link
Contributor

@nicmorales9 nicmorales9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, though the PR name should reflect that non-documentation changes are going in, and it would be nice to have a test showing the logic when it's been over 90s since the condition time was set

@johscheuer johscheuer changed the title Document the delay shutdown feature Document the delay shutdown feature and check in update Pods if pod is missing Jun 27, 2024
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: b057f2a
  • Duration 2:50:08
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 30c5dca
  • Duration 2:52:38
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer johscheuer closed this Jun 28, 2024
@johscheuer johscheuer reopened this Jun 28, 2024
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 30c5dca
  • Duration 2:37:17
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Copy link
Contributor

@nicmorales9 nicmorales9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test looks good

@johscheuer johscheuer merged commit f8d84ca into FoundationDB:main Jun 28, 2024
15 checks passed
@johscheuer johscheuer deleted the docs-delay-shutdown branch June 28, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fdb-kubernetes-monitor delay shutdown
3 participants