Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for isolating a process group in the operator #2068

Merged

Conversation

johscheuer
Copy link
Member

Description

Fixes: #1906

Operator support for apple/foundationdb#11464.

Type of change

Please select one of the options below.

  • New feature (non-breaking change which adds functionality)

Discussion

Testing

Added a new e2e test for that and ran it manually:

ReportAfterSuite] Autogenerated ReportAfterSuite for --junit-report
autogenerated by Ginkgo
[ReportAfterSuite] PASSED [0.003 seconds]
------------------------------

Ran 1 of 54 Specs in 424.461 seconds
SUCCESS! -- 1 Passed | 0 Failed | 10 Pending | 43 Skipped
PASS | FOCUSED
FAIL    github.com/FoundationDB/fdb-kubernetes-operator/e2e/test_operator       424.992s
FAIL

Documentation

Added the documentation for this new feature.

Follow-up

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 871a07e
  • Duration 2:53:00
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Copy link
Contributor

@nicmorales9 nicmorales9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this side looks good

@johscheuer johscheuer force-pushed the add-support-isolate-process-group branch from 871a07e to e2943cf Compare June 24, 2024 16:33
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: e2943cf
  • Duration 2:50:28
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer johscheuer merged commit f00ce96 into FoundationDB:main Jun 25, 2024
7 of 8 checks passed
@johscheuer johscheuer deleted the add-support-isolate-process-group branch June 25, 2024 10:57
@johscheuer
Copy link
Member Author

Test failure was:

• [FAILED] [433.262 seconds]
Operator when a Pod is unscheduled and another Pod is being replaced [It] should remove the targeted Pod [e2e, pr]
/codebuild/output/src503310604/src/github.com/FoundationDB/fdb-kubernetes-operator/e2e/test_operator/operator_test.go:584

  [FAILED] Timed out after 300.001s.
  Expected
      <bool>: false
  to be true
  In [It] at: /codebuild/output/src503310604/src/github.com/FoundationDB/fdb-kubernetes-operator/e2e/fixtures/fdb_cluster.go:1222 @ 06/24/24 17:14:25.628
------------------------------

The failure is unrelated and probably needs an increase in the timeout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to isolate Process Groups
3 participants