Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better error message when command failed and remove flaky check #2069

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

johscheuer
Copy link
Member

Description

Return the actual command that failed. Also remove the Eventually statement as that one was flaky, there was a race condition where the test detected the process and then the operator updated that Pod with the new version, which would cause the test to fail (as the process would be missing and MustPassRepeatedly(5) was set).

Type of change

Please select one of the options below.

  • Other

Discussion

Testing

Ran the tests manually.

Documentation

Follow-up

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 2048ad9
  • Duration 3:23:42
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 63a0de8
  • Duration 2:38:12
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer johscheuer merged commit 58afb9a into FoundationDB:main Jun 19, 2024
8 checks passed
@johscheuer johscheuer deleted the add-better-error-e2e branch June 19, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants