Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure to wait until the namespace is completely deleted #2070

Conversation

johscheuer
Copy link
Member

Description

We have seen a few cases where the same namespace name is used when the e2e tests are running, so we should be waiting in the test setup until the namespace is deleted before using it. Waiting for it to be deleted will recreate the namespace and all required resources.

Some test set a custom finalizer, this change checks for pods with a finalizer and resets them if one is set.

Type of change

Please select one of the options below.

  • Bug fix (non-breaking change which fixes an issue)

Discussion

Testing

CI will be running.

Documentation

Follow-up

@johscheuer johscheuer added the bug Something isn't working label Jun 19, 2024
Copy link
Contributor

@nicmorales9 nicmorales9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 071dd97
  • Duration 4:07:51
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer johscheuer closed this Jun 19, 2024
@johscheuer johscheuer reopened this Jun 19, 2024
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 071dd97
  • Duration 2:19:21
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer johscheuer closed this Jun 19, 2024
@johscheuer johscheuer reopened this Jun 19, 2024
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 071dd97
  • Duration 2:29:52
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer
Copy link
Member Author

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 071dd97
  • Duration 2:29:52
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Those test failures are unrelated to the changes and I'll be looking into them in another PR.

@johscheuer johscheuer merged commit 803c8fa into FoundationDB:main Jun 20, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants