Don't reset the last reconciled generation

[johscheuer]

Description

Fixes: #873

Type of change

Please select one of the options below.

• New feature (non-breaking change which adds functionality)

Discussion

Before that we would reset the generation to 0 which can be confusing in many cases when the reconciliation drops from a precious number to 0.

Testing

Ran unit tests and an e2e test suite.

Documentation

Not needed.

Follow-up

[foundationdb-ci]

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

• Commit ID: a93d80d
• Duration 2:32:53
• Result: ❌ FAILED
• Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

• Commit ID: a93d80d
• Duration 2:37:25
• Result: ✅ SUCCEEDED
• Error: N/A
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[nicmorales9]

Changes look good to me though it feels like it should not close the linked issue as it does not add the observedGenerations nor Conditions. If this is intentional, an explanation on the issue would be good

[johscheuer]

Changes look good to me though it feels like it should not close the linked issue as it does not add the observedGenerations nor Conditions. If this is intentional, an explanation on the issue would be good

For the conditions we have a dedicated issue: #1000. Adding the observedGeneration didn't seem to bring a huge value in this context.