Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor bug fixes for the e2e test suite #2074

Merged

Conversation

johscheuer
Copy link
Member

Description

Fix a few minor bugs in the e2e test suite where some global variables were used instead of the factory scoped variables. This caused that some tests reused the same namespace and in some rare cases it could cause independent test suites to use the same namespace, which obviously caused conflicts.

Type of change

Please select one of the options below.

  • Bug fix (non-breaking change which fixes an issue)

Discussion

Testing

Ran tests manually.

Documentation

Follow-up

@johscheuer johscheuer added the bug Something isn't working label Jun 21, 2024
@johscheuer johscheuer changed the title Minor bug fixes for the e2e test suire Minor bug fixes for the e2e test suite Jun 21, 2024
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 7bad58e
  • Duration 3:04:47
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: bf433d8
  • Duration 3:12:16
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: d57fa40
  • Duration 3:11:45
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer johscheuer closed this Jun 21, 2024
@johscheuer johscheuer reopened this Jun 21, 2024
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 7bad58e
  • Duration 2:50:19
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer johscheuer closed this Jun 24, 2024
@johscheuer johscheuer reopened this Jun 24, 2024
Copy link
Member Author

@johscheuer johscheuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failures in the last run:

  2024/06/21 17:02:58 reconciled name=fdb-cluster-v5i89er6, namespace=pr-947-rfdtai3c, generation:21
• [FAILED] [393.185 seconds]
Operator when a Pod is unscheduled and another Pod is being replaced [It] should remove the targeted Pod [e2e, pr]
/codebuild/output/src1254425878/src/github.com/FoundationDB/fdb-kubernetes-operator/e2e/test_operator/operator_test.go:583

  [FAILED] Timed out after 300.001s.
  Expected
      <bool>: false
  to be true
  In [It] at: /codebuild/output/src1254425878/src/github.com/FoundationDB/fdb-kubernetes-operator/e2e/fixtures/fdb_cluster.go:1222 @ 06/21/24 17:02:16.558
------------------------------

and

• [FAILED] [785.261 seconds]
Operator Upgrades with chaos-mesh upgrading a cluster with link that drops some packets [It] Upgrade from 7.1.57 to 7.3.33 with network link that drops some packets [e2e, pr]
/codebuild/output/src1254425878/src/github.com/FoundationDB/fdb-kubernetes-operator/e2e/fixtures/upgrade_test_configuration.go:115

  [FAILED] Unexpected error:
      <*errors.errorString | 0x2902340>: 
      timed out waiting for the condition
      {
          s: "timed out waiting for the condition",
      }
  occurred
  In [It] at: /codebuild/output/src1254425878/src/github.com/FoundationDB/fdb-kubernetes-operator/e2e/fixtures/fdb_cluster.go:1405 @ 06/21/24 16:54:42.427
------------------------------

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 7bad58e
  • Duration 2:35:25
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer johscheuer merged commit 6194efc into FoundationDB:main Jun 24, 2024
22 checks passed
@johscheuer johscheuer deleted the minor-bug-fixes-e2e-test-suite branch June 24, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants